Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: edit project-structure.md #91

Merged
merged 2 commits into from
Oct 7, 2022
Merged

docs: edit project-structure.md #91

merged 2 commits into from
Oct 7, 2022

Conversation

dejmedus
Copy link
Contributor

@dejmedus dejmedus commented Oct 7, 2022

PROJECT-STRUCTURE.md for issue #48

  • Caught a few minor typos.
  • Most comments started with a lowercase letter and ended without a period, so I changed all the comments to follow that structure.
  • Removed some instances of "this is", "all", or "contains" to keep comments concise.

@vercel
Copy link

vercel bot commented Oct 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
walkingpal-web ✅ Ready (Inspect) Visit Preview Oct 7, 2022 at 4:54AM (UTC)

ashuvssut
ashuvssut requested changes Oct 7, 2022
View reviewed changes
Copy link
Member

@ashuvssut ashuvssut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dejmedus! There are a few corrections and also you have to update the Credits link

.docs/PROJECT-STRUCTURE.md Outdated Show resolved Hide resolved
@dejmedus dejmedus requested a review from ashuvssut October 7, 2022 05:07
@ashuvssut ashuvssut merged commit 297c2e1 into WalkingPal:dev Oct 7, 2022
@ashuvssut
Copy link
Member

LGTM! Nice edits!

@ashuvssut ashuvssut added the hacktoberfest-accepted Marks accepted "valid" PRs label Oct 7, 2022
This was referenced Oct 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashuvssut ashuvssut Awaiting requested review from ashuvssut

Assignees
No one assigned
Labels
hacktoberfest-accepted Marks accepted "valid" PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dejmedus @ashuvssut